-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug dotnet/sdk-container-builds#559: PublishContainer Appends "dotnet <Target>.dll" to ENTRYPOINT for Self Contained Builds #40792
Bug dotnet/sdk-container-builds#559: PublishContainer Appends "dotnet <Target>.dll" to ENTRYPOINT for Self Contained Builds #40792
Conversation
3647099
to
54f65fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent find on the old test gap!
src/Containers/packaging/build/Microsoft.NET.Build.Containers.targets
Outdated
Show resolved
Hide resolved
test/Microsoft.NET.Build.Containers.IntegrationTests/TargetsTests.cs
Outdated
Show resolved
Hide resolved
7b67edd
to
d6193fb
Compare
…RYPOINT for Self Contained Builds * Fixed existing integration test that tested that ContainerEntryPoint can be deferred (it wasn't actually testing anything, due to a bug in the test) * Changed the test to test that we defer ContainerAppCommand instead (ContainerEntryPoint is not deferred anymore on .net 8) * Added runtime identifier dimension to the test (linux vs windows) * Fixed integration test ProjectInitializer to take into account Windows vs *nix when setting executable extension (.exe or nothing) * Fixed Microsoft.NET.Build.Containers.targets so that the behaviour is as expected on both Windows and linux containers
…ter align with e.g. OutputPath
d6193fb
to
151ef05
Compare
@tmds if you have a moment I'd love to get your eyes on this as well - I'm quite happy with the changes but you also have some history in this space. |
src/Containers/packaging/build/Microsoft.NET.Build.Containers.targets
Outdated
Show resolved
Hide resolved
src/Containers/packaging/build/Microsoft.NET.Build.Containers.targets
Outdated
Show resolved
Hide resolved
src/Containers/packaging/build/Microsoft.NET.Build.Containers.targets
Outdated
Show resolved
Hide resolved
Applied that fix and marked for merge. Thank you @erikbra for this contribution, and the related MSBuild issue writeup! |
Thanks for the follow-up, fix and merge, @baronfel ! I'm excited about which way the MsBuild issue/concern will go. I think that one's more deep-rooted in the core templates. |
Will/can this fix be backported to the .Net 8.0 sdk? |
Bug dotnet/sdk-container-builds#559: PublishContainer Appends "dotnet .dll" to ENTRYPOINT for Self Contained Builds
Fixes dotnet/sdk-container-builds#559