replace project-level Common.props imports with Directory.Build.props #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm still working on getting |
nguerrera
approved these changes
Feb 10, 2017
src/Directory.Build.props
Outdated
| @@ -0,0 +1,5 @@ | |||
| <Project ToolsVersion="14.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | |||
|
|
|||
| <Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), 'Common.props'))\Common.props" /> | |||
There was a problem hiding this comment.
Since you're opted into v15-only features already, you could simplify this file by dropping ToolsVersion and the namespace and changing this line to
<Import Project="$([MSBuild]::GetPathOfFileAbove('Common.props'))" />(That property function is new to MSBuild 15: dotnet/msbuild#1277)
dsplaisted
approved these changes
Feb 10, 2017
| @@ -1,6 +1,6 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | |||
| <Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" /> | |||
There was a problem hiding this comment.
Was this intentionall? I don't think the test projects would need to change.
There was a problem hiding this comment.
I'll back out this change.
There was a problem hiding this comment.
@jonsequitur This still isn't backed out
jonsequitur
force-pushed
the
BaseIntermediateOutputPath-fix
branch
2 times, most recently
from
8d102ab
to
e657a93
Compare
|
@srivatsn This is an infrastructure-only change. |
livarcocc
approved these changes
Feb 13, 2017
|
You can merge without needing approval since this is a infra change. |
jonsequitur
force-pushed
the
BaseIntermediateOutputPath-fix
branch
from
e657a93
to
ed34cb6
Compare
mmitche
added a commit
to mmitche/sdk
that referenced
this pull request
Jun 5, 2020
[release/3.0.1xx] Switch to prod pool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the Common.props imports from the projects under /test and /src and replaces them with Directory.Build.props.
This addresses #802.