MSBuildLocator 1.6.10 #214
Conversation
This fails in sourcebuild because we overwrite the TF to current ones, but that's kinda the point of source-build so it's not a _problem_.
rainersigwald
requested review from
MichaelSimons and
mthalman
as code owners
|
Roslyn - dotnet/roslyn#70038 |
|
@dibarbet - what version of dotnet is this intended to go into? |
I believe .net8 since that is what Roslyn main is targeting? |
This will need to be manually backported to the release/8.0 branch. This is currently blocking dotnet/installer#17395 |
On it. |
* DOTNET_ROOT handling changes and packages warning presence condition * MSBuild Locaton version update to 1.6.10 * Disable MSBuildLocator package validation This fails in sourcebuild because we overwrite the TF to current ones, but that's kinda the point of source-build so it's not a _problem_. --------- Co-authored-by: YuliiaKovalova <[email protected]>
* DOTNET_ROOT handling changes and packages warning presence condition * MSBuild Locaton version update to 1.6.10 * Disable MSBuildLocator package validation This fails in sourcebuild because we overwrite the TF to current ones, but that's kinda the point of source-build so it's not a _problem_. --------- Co-authored-by: YuliiaKovalova <[email protected]>
|
@MichaelSimons how do I get this to flow into dotnet/format? Do I need to pick up a dependency flow change PR - or should re-running the failed source build legs pick up the change eventually? |
|
I didn't find a darc subscription defined for dotnet/format so I defined it and triggered it - dotnet/format#1958 |
Thanks - I just asked Matt and suggested the same. I've rolled that update into dotnet/format#1957 as it also needs to update the actual referenced version |
This is #213 plus a fix to disable package validation, which doesn't make sense for the source-built package (which deliberately changes TFs).