Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how modern ArPow PVP works, plus context #2546

Closed
dagood opened this issue Oct 21, 2021 · 4 comments
Closed

Document how modern ArPow PVP works, plus context #2546

dagood opened this issue Oct 21, 2021 · 4 comments
Labels
area-doc Documentation improvements

Comments

@dagood
Copy link
Member

dagood commented Oct 21, 2021

There's an old doc with the initial design for PVP:
https://github.com/dotnet/source-build/blob/main/Documentation/auto-dependency-flow/api.md#file-format-package-version-props

I think ArPow needs a new doc that requires less context to understand, and adds new things that have come along since then. I think these would be useful:

  • PackageVersion vs. Version suffix?
  • What is the meaning of the RefOnly prefix in eng/Versions.props? (Or any other prefix?)
  • What are CurrentSourceBuiltPackageVersions.props and PreviouslySourceBuiltPackageVersions.props about?
  • What is the connection to Maestro++/BAR/Darc upgrades and eng/Version.Details.xml?
@dagood
Copy link
Member Author

dagood commented Oct 21, 2021

I wrote a description of PVP as I know it at dotnet/roslyn#57277 (comment), but it would be good to have a nice doc ready for this.

@MichaelSimons
Copy link
Member

[Triage] This should be done as part of the per repo pvp work. CC @oleksandr-didyk

@oleksandr-didyk
Copy link
Contributor

[Triage] This should be done as part of the per repo pvp work. CC @oleksandr-didyk

Reflected this in the original PvP issue for better tracking

@MichaelSimons
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-doc Documentation improvements
Projects
Archived in project
Development

No branches or pull requests

3 participants