-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build repo specific PackageVersions.props w/dependencies declared in Version.Details.xml #2482
Comments
This is required for #2979 |
Update on progress -> was finishing implementation for a different task (#2655) + have a Bootcamp to attend this week, will properly start with the issue on Friday, 09/09/2022 |
Update on progress -> FR week + Hacathon next week, most probably will not produce meaningful progress in the next week |
After initial investigation the current workload should probably be split into several separate issues due to the time and work required to accomplish a given milestone. Based on introduction from @MichaelSimons and my own inspection, the steps taken should be as follows:
Furthermore, there are several issues that are worth mentioning:
|
Once this functionality is picked up by each repo and within the tarball build, the existing infrastructure should be removed. |
This is certainly doable today with the current tarball creation process but becomes significantly more difficult with the VMR. We should discuss this at one of our syncs w/@premun and @crummel |
Thank you for reminding me about it, I will create a separate issue for it since it can be achieved only after the repos are on the new system, which can take some time |
Based on the info received on the sync, it seems that the |
@mmitche - was this completed with dotnet/installer#15267? I know we have the repo consumption side of this which is tracked in #3043. |
Yep, this is completed. |
Currently source-build build injects a PackageVersions.props into the repos builds that contains the current source-built package versions as well as all previously source built package versions. The result of this is that source-build does not behave the same as repo builds. Often times repos define Versions.props entries that are not auto-updated. They do not have a corresponding dependency in the Version.Details.xml file. Yet the way source-build works, these Versions.props entries are getting updated to use the source-built versions.
The solution to this is to build up a repo specific PackageVersions.props based on the dependencies defined in the Version.Details.xml. This will get source-build to build like the microsoft build and will be a forcing function to ensure the appropriate dependencies are defined (in order to eliminate pre-builts).
The text was updated successfully, but these errors were encountered: