Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consume project-specific PackageVersions.props file in end tarball build #3042

Closed
oleksandr-didyk opened this issue Sep 29, 2022 · 5 comments
Labels
area-arcade Common Arcade source-build infra

Comments

@oleksandr-didyk
Copy link
Contributor

oleksandr-didyk commented Sep 29, 2022

Part of #2482

Given all tarball-contributing repositories being able to produce PackageVersions.props file (#3043), the tarbal should be able to consume the individual files instead of the current logic of building the same file but for all projects combined.

Afterwards, a SB tarbal with the functionality would be produced and tested against to verify the changes made before making repo PvP the default behavior

@oleksandr-didyk
Copy link
Contributor Author

Expected implementation time -> 5-7 working days

@oleksandr-didyk oleksandr-didyk changed the title Consume project-specific PackageVersion.props file in end tarball build Consume project-specific PackageVersions.props file in end tarball build Sep 29, 2022
@MichaelSimons
Copy link
Member

Before this work starts in the tarball, this feature should be picked up by each individual repo contributing to the tarball build. Repos should opt in initially and once all onboarded the functionality should be on by default.

@oleksandr-didyk
Copy link
Contributor Author

Before this work starts in the tarball, this feature should be picked up by each individual repo contributing to the tarball build. Repos should opt in initially and once all onboarded the functionality should be on by default.

My bad, initially forgot about this, will edit the description

@oleksandr-didyk
Copy link
Contributor Author

Edited the issue description to properly reflect the pre-requisite for the task

@MichaelSimons
Copy link
Member

This is not needed. There will still be a single versions.props for everything in the source-built archive. A PackageVersions..Previous.props is generated at build time for each repo to pull in only the properties from source-build dependencies within the Version.Details.xml/

@MichaelSimons MichaelSimons closed this as not planned Won't fix, can't repro, duplicate, stale Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-arcade Common Arcade source-build infra
Projects
Archived in project
Development

No branches or pull requests

3 participants