Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid ref packs from getting bundled with produced packages #3486

Open
oleksandr-didyk opened this issue May 30, 2023 · 1 comment
Open
Labels
area-arcade Common Arcade source-build infra up-for-grabs

Comments

@oleksandr-didyk
Copy link
Contributor

oleksandr-didyk commented May 30, 2023

In the past we have encountered issues where a project would bundle a ref pack for one of its dependencies into the produced package. If a downstream repo would then run the library / text pack during the build, the bundled ref pack would get loaded in, failing the build.

Example - Nuget.ProjectModel 6.2.2 would be bundled with one of the Arcade's packages. SBRP contained a ref pack for this dependency, which would get included in the produced intermediate. runtime would then execute the package during the build, resulting in the ref pack getting loaded in, failing the build (see dotnet/source-build-reference-packages#673 (comment)).

We should add a check for this in Arcade's tooling, warning / failing if such a situation is encountered.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@oleksandr-didyk oleksandr-didyk changed the title Forbid including a ref pack into an intermediate Forbid ref packs from getting bundled with produced packages May 30, 2023
@MichaelSimons MichaelSimons added area-arcade Common Arcade source-build infra and removed untriaged labels Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-arcade Common Arcade source-build infra up-for-grabs
Projects
Status: 10.0
Development

No branches or pull requests

2 participants