-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove nuget 6.2.2 #673
remove nuget 6.2.2 #673
Conversation
Presumably, tasks packages don't need to bundle NuGet assemblies at all. NuGet is already part of the SDK and available when invoked via Desktop's msbuild. @rainersigwald @dsplaisted @nkolev92 can you please double check my assumption? |
For |
That should be good enough for source build. I will update the Arcade packages and ApiCompat/GenAPI in dotnet/sdk to not bundle NuGet assemblies in the package for .NETCoreApp. |
The removal of these 6.2.2 packages breaks the per-repo-PVP work for Arcade. Arcade is one of the first things that gets built in SB. So if it can't use SBRP the only other option is PSB (6.7.0-preview... instead of 6.2.2). Would such a newer version be acceptable for repos consuming Arcade? |
We don't bundle NuGet assemblies into the Arcade packages for .NETCoreApp anymore. Are you sure that they are still required for sourcebuild? |
@ViktorHofer - Are you saying it should be safe to add back NuGet 6.2.2 to SBRP and things won't be broken now because Arcade won't pass on ref assemblies in its packages anymore? |
Exactly. Arcade now only needs NuGet assemblies to compile against the contract, without invoking or bundling them. |
This reverts commit a74fb65.
This reverts commit a74fb65.
Required by dotnet/runtime#86151 (comment) and dotnet/roslyn#67436 (comment)
The SBRP version of Nuget gets included in packages produced by Arcade. When some of these packages are then used by repo's like
runtime
, they try to load in the packaged Nuget, resulting in an exception (see dotnet/runtime#86151 (comment)).This PR removes the affected version with Arcade having it baselined until an intermediate for latest version will be available (see https://github.com/dotnet/arcade/pull/13027/files#diff-f88ce4026366ce74fb1a981785c542757617abf4393a33ca34465a5e9a0dd343R5)