Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement subset source-only build branches #3989

Closed
8 tasks done
mmitche opened this issue Jan 19, 2024 · 9 comments
Closed
8 tasks done

Implement subset source-only build branches #3989

mmitche opened this issue Jan 19, 2024 · 9 comments

Comments

@mmitche
Copy link
Member

mmitche commented Jan 19, 2024

Follow on work from discussions here: #3738

Based on this discussion, the following will happen:

  • We will change the VMR sync such that it will sync into a branch without cloaking. Let's call this the VMR-All branch
  • We will provide a distro-maintainer-centric branch which will comply with your requirements like the existing branch does.
  • This branch will be a subset of the VMR-All branch, related in git history. Let's call this a VMR-SourceOnly branch. It will have the cloaked set of files removed.
  • These cloaked files may also include repos that are not interesting for distro maintainers, e.g. winforms
  • PRs that update a VMR-All branch will also test updates to the corresponding VMR-SourceOnly branch.
  • Upon checkin, the VMR-SourceOnly branch will be immediately updated (no lag) via a merge process.
  • On release day, we will create two tags and two releases. One tag will point to the VMR-All content for the release, and the other to the source only compatible content.

Design Details

Branch Naming

  • Primary branch names (e.g. main and release/8.0.1xx) remain unchanged.
  • Source-only branches are named with a /source-only suffix: (e.g. main/source-only and release/8.0.1xx/source-only)

Release Tag Naming

  • Primary tag names are unchanged from previous names. (e.g. v8.0.1)
  • Source-only tags are named with a -source-only suffix (e.g. v8.0.0-source-only).

Release content

  • Release content for the primary tag is updated to indicate the tag that should be used for source-only builds
  • Source-build release content is updated to indicate that the tag should be used for source-only builds.

Work Items

Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@mmitche
Copy link
Member Author

mmitche commented Jan 19, 2024

@premun

@jkotas
Copy link
Member

jkotas commented Jan 19, 2024

Source-only branches are named with a /source-only suffix:

The key characteristic of these branches is that they are tailored to the needs of Unix distros. Should the suffix naming reflect that? E.g. unix-distro suffix?

@mmitche
Copy link
Member Author

mmitche commented Jan 19, 2024

Source-only branches are named with a /source-only suffix:

The key characteristic of these branches is that they are tailored to the needs of Unix distros. Should the suffix naming reflect that? E.g. unix-distro suffix?

Maybe distro-maintainer? I'm fine with any naming here as long as it's pretty clear to users.

@premun
Copy link
Member

premun commented Jan 23, 2024

Maybe it's better to say what is in the branch (like /source-only) rather than trying to describe the purpose of how it should be used as that can grow/change over time?
E.g. we might start using these for some non-distro-related purpose?

@mmitche
Copy link
Member Author

mmitche commented Jan 23, 2024

Possibly. @MichaelSimons and I chatted more about this yesterday and he doesn't love the delta-branch approach much. Let's chat more tomorrow. It's possible that we could keep a set of cloaking and use the same branch, but this will require time to evaluate.

@mmitche
Copy link
Member Author

mmitche commented Jan 31, 2024

It's likely this work will not be required as we may use a pre-build script for distro maintainers. If not, we should close all items and open a new Epic + items for that.

@mmitche
Copy link
Member Author

mmitche commented Feb 2, 2024

Going with a different solution in #4088

@mmitche mmitche closed this as completed Feb 2, 2024
@tkapin
Copy link
Member

tkapin commented Feb 15, 2024

Going with a different solution in #4088

Since we are going with a different solution, I'm removing the Epic label to get this off of the roadmap.

@tkapin tkapin removed the Epic Groups multiple user stories. Can be grouped under a theme. label Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Status: Done
Development

No branches or pull requests

4 participants