Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cloaking from primary VMR sync #3990

Closed
Tracked by #3989
mmitche opened this issue Jan 19, 2024 · 2 comments
Closed
Tracked by #3989

Remove cloaking from primary VMR sync #3990

mmitche opened this issue Jan 19, 2024 · 2 comments

Comments

@mmitche
Copy link
Member

mmitche commented Jan 19, 2024

Remove cloaking from the sync of the VMR to the 'primary' branch. Note: It is possible that some exclusions may remain in the primary VMR branch. Design accordingly.

@mmitche mmitche changed the title Remove exclusions from primary VMR sync Remove cloaking from primary VMR sync Jan 19, 2024
@premun premun self-assigned this Jan 29, 2024
@premun
Copy link
Member

premun commented Jan 29, 2024

As agreed, I have prepared the new VMR branch main-ub - https://github.com/dotnet/dotnet/tree/main-ub.
I have deleted all contents of the VMR and initialized it using the tooling without the cloakings. I then squashed these changes.
The result is this commit (on top of main): dotnet/dotnet@ef08898 which adds 663 binaries (patch size for this would be 66.7MB).

The synchronization pipeline now runs 2 jobs:
https://dev.azure.com/dnceng/internal/_build/results?buildId=2363056&view=results

@premun premun closed this as completed Jan 29, 2024
@mmitche mmitche reopened this Jan 29, 2024
@premun premun removed their assignment Jan 31, 2024
@MichaelSimons
Copy link
Member

This is superseded by #4088.

@MichaelSimons MichaelSimons closed this as not planned Won't fix, can't repro, duplicate, stale Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants