Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release 9.0.1xx] VerifyVersionFile Failing Due to Mismatched Version #4682

Closed
ellahathaway opened this issue Oct 18, 2024 · 6 comments
Closed
Assignees
Labels
ops-monitor Issues created/handled by the source build monitor role untriaged

Comments

@ellahathaway
Copy link
Member

ellahathaway commented Oct 18, 2024

Regression caused by dotnet/sdk#44289

The SourceBuiltArtifactsTests.VerifyVersionFile is failing in all 9.0.1xx builds because the test expects the SDK version to be 9.0.100-rtm.24517.1 but it is 9.0.100.

The expected version is pulled from the source-built SDK, and the actual version is pulled from the private-source-built artifacts. This means that the SDK version is still 9.0.100-rtm.24517.1.

cc @marcpopMSFT

@ellahathaway ellahathaway added the ops-monitor Issues created/handled by the source build monitor role label Oct 18, 2024
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

1 similar comment
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@ellahathaway
Copy link
Member Author

ellahathaway commented Oct 18, 2024

The expected SDK version is being pulled as the unique, non-stable version.

I think that to fix this we can either 1) adjust the DetermineSourceBuildSdkVersion to pull the non-stable version from the sdk artifact & version the Private.SourceBuilt.Artifacts as the rtm version (this would lead to a mismatch in artifact versions between the source-built SDK and the Private.SourceBuilt.Artifacts), 2) adjust the test to use the stable version if we are using an rtm version for the non-stable SDK version (this requires that IsShippable is set to true), or 3) something I'm not thinking of.

cc @dotnet/source-build

@NikolaMilosavljevic
Copy link
Member

This should work fine - I have fixed similar issue in the past: dotnet/sdk@70c717b, PR: dotnet/installer#17819

SDK version file contains both stable and non-stable versions, here's a sample content from one of the recent SDK builds:

d110decbb1b2ce9df1afe0d1ae1605b96fcea940
9.0.100
linux-x64
9.0.100-rtm.24520.5
9.0.100

@NikolaMilosavljevic
Copy link
Member

The issue is with version in PSB archive, it is 9.0.100

@NikolaMilosavljevic
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ops-monitor Issues created/handled by the source build monitor role untriaged
Projects
Archived in project
Development

No branches or pull requests

2 participants