Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SourceBuiltRepoToolsetSdkResolver (our workaround for MSBuild NuGet SDK resolver inflexibility) #590

Open
dagood opened this issue Jun 7, 2018 · 1 comment
Labels
area-build Improvements in source-build's own build process

Comments

@dagood
Copy link
Member

dagood commented Jun 7, 2018

Right now, we use it to avoid modifying both the NuGet.Config and global.json to point to a source-built SDK. Ideally we should be able to pass parameters that customize the sources and versions. We need dotnet/msbuild#2914 to do this.

Another alternative is to replace SourceBuiltRepoToolsetSdkResolver with some file replacing in nuget.config and global.json, if SourceBuiltRepoToolsetSdkResolver itself is a maintenance cost. (So far I'm not aware of any.)

/cc @eerhardt @dseefeld @crummel

@dagood dagood added the area-build Improvements in source-build's own build process label Jun 7, 2018
@MichaelSimons
Copy link
Member

[Triage] source-build modifies the global.json to specify the SDK. With the VMR, it would be possible to cloak away the repos global.json and nuget.config then use a common shared VMR version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-build Improvements in source-build's own build process
Projects
Status: Backlog
Development

No branches or pull requests

3 participants