Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional configuration of restore settings used by NuGet SDK resolver #2914

Open
natemcmaster opened this issue Jan 25, 2018 · 2 comments
Labels

Comments

@natemcmaster
Copy link
Contributor

Follow up to #2803

The NuGet SDK resolver currently only supports using NuGet.config for restore settings. NuGet.config is not expressive enough to allow conditionally changing settings, and there are currently no plans to change that. Instead, users are instructed to use /target:Restore and MSBuild properties to conditionally configure restore settings. However, these properties are not available during the SDK resolution phase, so they cannot be used to control the restore used by the NuGet SDK resolver.

It would be great to provide ways to control restore settings in way that is consistent between the NuGet SDK resolver and /t:Restore.

@dasMulli
Copy link
Contributor

It would be great to allow env vars or command line settings (-> Directory.Build.rsp) to override the nuget config used and/or specify sources.

@weshaggard
Copy link
Member

On top of configuring the source we need a way to configure the version that doesn't require it to be hard-coded in the projects or global.json. There are scenarios like source-build where we build all the repo's that make up the .NET Core product and they need to use a version of an sdk that was built from source and so we need a way to tell all the repo's to use that version without necessary committing or overwriting changes in every repo.

natemcmaster pushed a commit to dotnet/efcore that referenced this issue May 16, 2018
@jeffkl jeffkl removed their assignment May 21, 2018
natemcmaster added a commit to dotnet/Scaffolding that referenced this issue May 23, 2018
natemcmaster added a commit to dotnet/Scaffolding that referenced this issue May 23, 2018
natemcmaster added a commit to dotnet/Scaffolding that referenced this issue May 23, 2018
dougbu added a commit to aspnet/Mvc that referenced this issue Oct 4, 2018
- should resolve issues with occasional strange MSBuild caching issues in this repo
- modeled after dotnet/Scaffolding#905
- follows aspnet/BuildTools#729 recommendation to check in global.config file
  - see also dotnet/msbuild#2914
dougbu added a commit to aspnet/Mvc that referenced this issue Oct 4, 2018
- should resolve issues with occasional strange MSBuild caching issues in this repo
- modeled after dotnet/Scaffolding#905
- follows aspnet/BuildTools#729 recommendation to check in global.config file
  - see also dotnet/msbuild#2914
- use newer KoreBuild
  - `.\build.cmd -update /t:noop`
@AR-May AR-May added the triaged label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants