This repository has been archived by the owner on Sep 13, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 428
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use a file list rather than globbing NETStandard assemblies
This change minimizes the amount of work done during project evaluation by directly setting the reference items to all the files/paths we know are part of the package.
- Loading branch information
Showing
3 changed files
with
42 additions
and
37 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
29 changes: 23 additions & 6 deletions
29
netstandard/pkg/targets/netstandard/NETStandard.Library.targets
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,29 @@ | ||
<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
<PropertyGroup> | ||
<NETStandardLibraryPackageVersion>#VERSION#</NETStandardLibraryPackageVersion> | ||
</PropertyGroup> | ||
|
||
<!-- Only add references if we're actually targeting .NETStandard. | ||
If the project is targeting some other TFM that is compatible with NETStandard we expect | ||
that framework to provide all references for NETStandard, mscorlib, System.* in their own | ||
targeting pack / SDK. --> | ||
<PropertyGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETStandard'"> | ||
<_NetStandardLibraryRefPath>$(MSBuildThisFileDirectory)\ref\</_NetStandardLibraryRefPath> | ||
</PropertyGroup> | ||
|
||
<!-- import the TFM-agnostic targets --> | ||
<Import Project="..\$(MSBuildThisFile)"/> | ||
<ItemGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETStandard'"> | ||
<Reference Include="$(MSBuildThisFileDirectory)\ref\netstandard.dll"> | ||
<!-- Private = false to make these reference only --> | ||
<Private>false</Private> | ||
<!-- hide these from Assemblies view in Solution Explorer, they will be shown under packages --> | ||
<Visible>false</Visible> | ||
<NuGetPackageId>NETStandard.Library</NuGetPackageId> | ||
<NuGetPackageVersion>$(NETStandardLibraryPackageVersion)</NuGetPackageVersion> | ||
</Reference> | ||
<Reference Include="#NETSTANDARDFACADES#"> | ||
<Facade>true</Facade> | ||
<!-- Private = false to make these reference only --> | ||
<Private>false</Private> | ||
<!-- hide these from Assemblies view in Solution Explorer, they will be shown under packages --> | ||
<Visible>false</Visible> | ||
<NuGetPackageId>NETStandard.Library</NuGetPackageId> | ||
<NuGetPackageVersion>$(NETStandardLibraryPackageVersion)</NuGetPackageVersion> | ||
</Reference> | ||
</ItemGroup> | ||
</Project> |