This repository has been archived by the owner on Sep 13, 2022. It is now read-only.
Add ValueTuple to .NET Standard 2.0 #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Thanks :-) |
|
@weshaggard yes, System.ValueTuple is included in an upcoming version (with preview available very soon) and it matches the api and public key |
|
We added ValueTuple to mscorlib, but we have the System.ValueTuple.dll facade as well. |
|
@akoeplinger I'm going to go ahead and merge the outstanding PR's. Given that I don't have ready access to the exact factoring of the Xamarin profiles would you mind submitting a PR to cover the recent additions? Thanks. |
weshaggard
force-pushed
the
AddValueTuple
branch
from
6e57138
to
c3059cb
Compare
50 tasks
|
@weshaggard yes, sure. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22
cc @ericstj @terrajobst @jcouv
@marek-safar @akoeplinger is ValueTuple already included in Xamarin? If so does it match the surface area and assembly identity?