This repository has been archived by the owner on Sep 13, 2022. It is now read-only.
Use a file list rather than globbing NETStandard assemblies #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change minimizes the amount of work done during project evaluation by directly setting the reference items to all the files/paths we know are part of the package.
weshaggard
reviewed
Sep 22, 2017
| <NuGetPackageId>NETStandard.Library</NuGetPackageId> | ||
| <NuGetPackageVersion>$(NETStandardLibraryPackageVersion)</NuGetPackageVersion> | ||
| </Reference> | ||
| <Reference Include="#NETSTANDARDFACADES#"> |
There was a problem hiding this comment.
That is going to turn into a pretty long include string. Are there any limits in the length of that over just having one item per facade?
There was a problem hiding this comment.
Not that I am aware of. MSBuild is using managed code to parse this thing so its not like we impose any limits on strings in a file. I'm trying to keep the overall text size down as well because I don't want to increase the file size/parsing by a ton.
weshaggard
approved these changes
Sep 22, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change minimizes the amount of work done during project evaluation by directly
setting the reference items to all the files/paths we know are part of the package.
/cc @weshaggard @davkean
#442