-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document reserved aliases #5269
Conversation
Looks good. Let's improve this article to explain Example of it can be found here: https://github.com/dotnet/sdk/blob/main/template_feed/Microsoft.DotNet.Common.ProjectTemplates.7.0/content/ClassLibrary-CSharp/.template.config/dotnetcli.host.json It allows the following:
Also it would be good to have unit/integration tests on it. Help tests test it in away though. We do have some unit tests here: https://github.com/dotnet/sdk/blob/main/src/Tests/Microsoft.TemplateEngine.Cli.UnitTests/HostDataLoaderTests.cs |
I'd like to dive into host file and improve this article as well as tests. |
Very nice and valuable overview! Looking forward the addition of host files parameters altering functionality |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, suggesting some changes below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added couple of suggestions.
e5646b1
to
255ef78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Problem
#5198
Solution
Add doc for reserved aliases since .NET 7.0, as well as reference for dotnetcli.host.json.
Add unit tests dotnet/sdk#28748
Checks:
#nullable enable
to all the modified files ?