Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O# Parity] Project loading support for projects running on Mono #5721

Closed
Tracked by #5736
dibarbet opened this issue Jun 8, 2023 · 2 comments · Fixed by dotnet/roslyn#69616 or dotnet/roslyn#70263
Closed
Tracked by #5736

[O# Parity] Project loading support for projects running on Mono #5721

dibarbet opened this issue Jun 8, 2023 · 2 comments · Fixed by dotnet/roslyn#69616 or dotnet/roslyn#70263
Assignees
@jasonmalinowski
Labels
Omnisharp-Parity Triaged
Milestone
October2023

Comments

@dibarbet
Copy link
Member

dibarbet commented Jun 8, 2023

For the C# project loader, we need to run our design time builds out of proc using the project specific SDK. This will avoid errors trying to load various project types in the .NET 7 runtime.

With out of proc design time builds, we should also be able to load mono / legacy csproj (similar to O#'s useModernDotnet flag).

Note that this is only planned to be supported in the C# extension project loader.
@mikadumont mikadumont mentioned this issue Jun 8, 2023
Open
10 tasks
@dibarbet dibarbet mentioned this issue Jun 21, 2023
Closed
@dibarbet dibarbet mentioned this issue Aug 3, 2023
Closed
@arunchndr arunchndr mentioned this issue Aug 4, 2023
Closed
@arunchndr arunchndr added this to the August milestone Aug 7, 2023
@arunchndr arunchndr mentioned this issue Aug 7, 2023
Closed
@dibarbet dibarbet mentioned this issue Aug 7, 2023
Closed
This was referenced Aug 11, 2023
Closed
Closed
@dibarbet dibarbet mentioned this issue Aug 19, 2023
Closed
@arunchndr arunchndr mentioned this issue Aug 24, 2023
Closed
@jasonmalinowski jasonmalinowski mentioned this issue Aug 26, 2023
Merged
12 tasks
@jasonmalinowski
Copy link
Member

Didn't quite mean to close this yet, but dotnet/roslyn#69616 brings significant improvements here and adds legacy support for .NET Framework projects on Windows. Mac/Linux for stuff running atop Mono should come soon.

@jasonmalinowski jasonmalinowski changed the title [O# Parity] Out of proc design time builds / legacy csproj support [O# Parity] Project loading support for projects running on Mono Sep 5, 2023
@vchirikov vchirikov mentioned this issue Sep 6, 2023
Closed
@dibarbet dibarbet mentioned this issue Sep 15, 2023
Closed
@arunchndr arunchndr modified the milestones: August, October Oct 2, 2023
jasonmalinowski added a commit to jasonmalinowski/roslyn that referenced this issue Oct 5, 2023
@jasonmalinowski
Add support for using Mono to load .NET Framework projects
9b0e7f1 
We'll use this on Mac and Linux; we already had equivalent support
on Windows. MonoMSBuildDiscovery.cs is largely a copy of the code
from these paths, with some tweaks to remove Omnisharp scenarios
that don't apply for us.

- https://github.com/OmniSharp/omnisharp-roslyn/blob/dde8119c40f4e3920eb5ea894cbca047033bd9aa/src/OmniSharp.Host/MSBuild/Discovery/Providers/MonoInstanceProvider.cs
- https://github.com/OmniSharp/omnisharp-roslyn/blob/dde8119c40f4e3920eb5ea894cbca047033bd9aa/src/OmniSharp.Host/MSBuild/Discovery/MSBuildInstanceProvider.cs

Closes dotnet/vscode-csharp#5721
@jasonmalinowski jasonmalinowski mentioned this issue Oct 5, 2023
Merged
jasonmalinowski added a commit to jasonmalinowski/roslyn that referenced this issue Oct 6, 2023
@jasonmalinowski
Add support for using Mono to load .NET Framework projects
1bacac5 
We'll use this on Mac and Linux; we already had equivalent support
on Windows. MonoMSBuildDiscovery.cs is largely a copy of the code
from these paths, with some tweaks to remove Omnisharp scenarios
that don't apply for us.

- https://github.com/OmniSharp/omnisharp-roslyn/blob/dde8119c40f4e3920eb5ea894cbca047033bd9aa/src/OmniSharp.Host/MSBuild/Discovery/Providers/MonoInstanceProvider.cs
- https://github.com/OmniSharp/omnisharp-roslyn/blob/dde8119c40f4e3920eb5ea894cbca047033bd9aa/src/OmniSharp.Host/MSBuild/Discovery/MSBuildInstanceProvider.cs

Closes dotnet/vscode-csharp#5721
@jasonmalinowski
Copy link
Member

With #70263 being merged in Roslyn, we should now have support for all the MSBuild-based projects that Omnisharp also supported. There's still some non-MSBuild project types to look at, but we should have the same compat across all platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasonmalinowski jasonmalinowski

Labels
Omnisharp-Parity Triaged
Projects
None yet
Milestone
October2023
3 participants
@jasonmalinowski @dibarbet @arunchndr