Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Razor and Roslyn to respond to Razor serialization changes #7384

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

davidwengier
Copy link
Contributor

@davidwengier davidwengier commented Jul 23, 2024

Razor going from 87b4727a3e721a1766a759133fcf35333648a143 to fd837e1f2df38690099059b0a315ed6eadd6d472.
Diff: dotnet/razor@87b4727...fd837e1

@davidwengier davidwengier requested a review from a team as a code owner July 23, 2024 00:44
@davidwengier
Copy link
Contributor Author

Forgot to run updateRoslynVersion too 🤦‍♂️

@davidwengier
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@dibarbet dibarbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're planning on updating Razor again later this week feel free to ignore the changelog update for now. Roslyn one can be ignored (will be updated again soon)

CHANGELOG.md Outdated
@@ -15,6 +15,11 @@
* Renamed settings (PR: [#7356](https://github.com/dotnet/vscode-csharp/pull/7356))
* `dotnet.implementType.insertionBehavior` to `dotnet.typeMembers.memberInsertionLocation`
* `dotnet.implementType.propertyGenerationBehavior` to `dotnet.typeMembers.propertyGenerationBehavior`
* Update Razor to 9.0.0-preview.24366.2 (PR: [#7384](https://github.com/dotnet/vscode-csharp/pull/7384))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be in a new section now (and this one renamed to 2.40.x

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I alway get this wrong

@davidwengier davidwengier merged commit 089f6fc into dotnet:main Jul 23, 2024
13 checks passed
@davidwengier davidwengier deleted the BumpRazorAndRoslyn branch July 23, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants