Don't set HOME environment variable #1923
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Activation our Extension sets the HOME variable causing Git to no longer function.
Resolves #1795
Resolves #1400
Resolves #1686
Resolves #1707
Resolves #1916
This import statement in our code on
WebRequestWorker.ts
sets HOME.How do I know? I used the SysInternals Process Explorer to read the environment for every vscode sub process and went through the decompiled JS line by line in a binary search to see which line of code causes HOME to change 🥱
HOME is no longer changed.
This is definitely one of the weirdest bugs Ive had to solve.... seriously. We checked the source code this library and they dont edit HOME either, probably their 1 of dependencies does. But it doesn't really matter.