Add PATH for Arm emulation x64 on Mac #1932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
MiYanni
approved these changes
Sep 5, 2024
vscode-dotnet-runtime-library/src/Acquisition/WinMacGlobalInstaller.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Michael Yanni <[email protected]>
|
Waiting to see if I can get a mac to do this better or not. |
|
Otherwise, this PR is ready to go. |
|
Getting a mac has still taken a while. I am going to merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the PATH is not found even though the installer succeeds. This adds a check to see if it might be the other mac path that the installer can use. I believe this is the only other path it can use. https://github.com/dotnet/sdk/blob/a620dca0942ca7b9bcd7b6dac2b847e5b46afe7e/src/Installer/redist-installer/targets/GeneratePKG.targets#L17
I could not get my hands on a mac m1 that worked despite trial and tribulation (except for like buying one myself for this one bug) so this will add a check to see if it installed in this emulation path.
Theoretically it shouldnt be possible to have an architecture mismatch but I dont know what values os.platform and arch will return if its on an emulated architecture.