Restore Packing/Publishing the Extension to a Working State #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilson/vscode-dotnet-runtime into nagilson-publish-package-fix
nagilson
added
bug
nagilson
changed the title
nagilson
changed the title
NTaylorMullen
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The steps that pack the extension into an actual vscode extension normally don't run unless they're on main, which prevented us from seeing that the new registry broke those steps, as well as other items that caused them to break while the repository was gaining dust.
This PR addresses these items by fixing/adding yarn.locks to match the registry, changing pipeline to lock package versions for vscode extension packaging, makes that step a verification in all pipelines.
For any change made to a package-lock, yarn add package@version will also be needed to keep them in sync. Another PR #617 creates a pipeline step which will fail if it observes a change in npm locks but not yarn locks.