Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable shipping dotnet-svcutil.xmlserializer as needed. #3975

Closed
2 tasks done
StephenBonikowsky opened this issue Oct 17, 2019 · 1 comment · Fixed by #3995
Closed
2 tasks done

Enable shipping dotnet-svcutil.xmlserializer as needed. #3975

StephenBonikowsky opened this issue Oct 17, 2019 · 1 comment · Fixed by #3995
Assignees
@StephenBonikowsky
Labels
Net Core 3.1 LTS Servicing Tasks planned for the WCF NET Core 3.1 Servicing releases.
Milestone
3.1.x

Comments

@StephenBonikowsky
Copy link
Member

StephenBonikowsky commented Oct 17, 2019 •
edited
Loading

By default the dotnet-svcutil.xmlserializer project will not produce shippable packages. Add a property that can be set manually at build time that will set to true on the project.
@StephenBonikowsky StephenBonikowsky added this to the 3.1 milestone Oct 17, 2019
@StephenBonikowsky StephenBonikowsky self-assigned this Oct 17, 2019
@StephenBonikowsky StephenBonikowsky mentioned this issue Oct 17, 2019
Merged
StephenBonikowsky added a commit to StephenBonikowsky/wcf that referenced this issue Oct 25, 2019
@StephenBonikowsky
Enable or disable shipping different packages.
33ef493 
* By default always ship WCF packages.
* By default do not ship dotnet-svcutil.xmlserializer packages.
* Enable or disable either one by setting their respective properties to true or false, can be done from the build definition that produces final release packages.
* Fixes dotnet#3975
StephenBonikowsky added a commit to StephenBonikowsky/wcf that referenced this issue Oct 25, 2019
@StephenBonikowsky
Enable or disable shipping different packages.
9ea864a 
* By default always ship WCF packages.
* By default do not ship dotnet-svcutil.xmlserializer packages.
* Enable or disable either one by setting their respective properties to true or false, can be done from the build definition that produces final release packages.
* Fixes dotnet#3975
@StephenBonikowsky StephenBonikowsky mentioned this issue Oct 25, 2019
Merged
StephenBonikowsky added a commit to StephenBonikowsky/wcf that referenced this issue Nov 4, 2019
@StephenBonikowsky
Enable or disable shipping different packages.
43d87b0 
* By default always ship WCF packages.
* By default do not ship dotnet-svcutil.xmlserializer packages.
* Enable or disable either one by setting their respective properties to true or false, can be done from the build definition that produces final release packages.
* Fixes dotnet#3975
StephenBonikowsky added a commit to StephenBonikowsky/wcf that referenced this issue Nov 4, 2019
@StephenBonikowsky
Enable or disable shipping different packages.
f9ab67a 
* By default always ship WCF packages.
* By default do not ship dotnet-svcutil.xmlserializer packages.
* Enable or disable either one by setting their respective properties to true or false, can be done from the build definition that produces final release packages.
* Fixes dotnet#3975
@StephenBonikowsky StephenBonikowsky modified the milestones: 3.1, 3.1.1 Jan 6, 2020
@StephenBonikowsky StephenBonikowsky added the Net Core 3.1 LTS Servicing Tasks planned for the WCF NET Core 3.1 Servicing releases. label Jan 6, 2020
@StephenBonikowsky StephenBonikowsky modified the milestones: 3.1.1, 3.1.x Jan 24, 2020
@StephenBonikowsky
Copy link
Member Author

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StephenBonikowsky StephenBonikowsky

Labels
Net Core 3.1 LTS Servicing Tasks planned for the WCF NET Core 3.1 Servicing releases.
Projects
None yet
Milestone
3.1.x
Development

Successfully merging a pull request may close this issue.

Enable or disable shipping different packages. StephenBonikowsky/wcf
1 participant
@StephenBonikowsky