Add new exception handling logic for SocketsHttpHandler differences #2668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mconnew
added
the
PR DO NOT MERGE
|
Only test failing now looks to be digest authentication. This is likely a protocol error in either the WCF service side digest authentication component I wrote or the digest protocol support in SocketsHttpHandler. I'll investigate to work out which it is. |
mconnew
force-pushed
the
ChangesForSocketsHttpHandler
branch
2 times, most recently
from
9f8a0cd
to
2c1764f
Compare
|
@dotnet-bot test outerloop Windows_NT |
mconnew
force-pushed
the
ChangesForSocketsHttpHandler
branch
from
2c1764f
to
fac0502
Compare
mconnew
removed
the
PR DO NOT MERGE
KKhurin
approved these changes
Mar 26, 2018
StephenBonikowsky
added a commit
to StephenBonikowsky/wcf
that referenced
this pull request
Aug 15, 2018
* HttpClientHandler for uap does not support a non-NetworkCredentialManager type. * #if/#endif ...ing the piece of code that is causing this PNSE error. * Regression was introduced via: dotnet#2668
StephenBonikowsky
added a commit
to StephenBonikowsky/wcf
that referenced
this pull request
Aug 16, 2018
* HttpClientHandler for uap does not support a non-NetworkCredentialManager type. * #if/#endif ...ing the piece of code that is causing this PNSE error. * Regression was introduced via: dotnet#2668
StephenBonikowsky
added a commit
to StephenBonikowsky/wcf
that referenced
this pull request
Aug 16, 2018
* HttpClientHandler for uap does not support a non-NetworkCredentialManager type. * #if/#endif ...ing the piece of code that is causing this PNSE error. * Regression was introduced via: dotnet#2668
StephenBonikowsky
added a commit
to StephenBonikowsky/wcf
that referenced
this pull request
Aug 16, 2018
* HttpClientHandler for uap does not support a non-NetworkCredentialManager type. * #if/#endif ...ing the piece of code that is causing this PNSE error. * Regression was introduced via: dotnet#2668
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added changes needed for failure modes with SocketsHttpHandler as it throws different exceptions than the previous HttpClientHandler implementations.
Switched to using CredentialCache to restrict credentials to a single authentication mechanism. This matches the full framework behavior.
Improved the DigestAuthentication request validation to fail if the client sends authentication headers which aren't digest.