Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix certificate chain validation VerificationTime issue #3086

Merged

Conversation

mconnew
Copy link
Member

@mconnew mconnew commented Aug 2, 2018

No description provided.

@StephenBonikowsky
Copy link
Member

@dotnet-bot test all outerloop please

1 similar comment
@mconnew
Copy link
Member Author

mconnew commented Nov 29, 2018

@dotnet-bot test all outerloop please

@StephenBonikowsky
Copy link
Member

This fix was cherry-picked from VSTS directly into release/2.1.0 therefore skipping the PR step.
Re-running the tests to get green before merging.

@StephenBonikowsky
Copy link
Member

@dotnet-bot test outerloop Windows_NT

@StephenBonikowsky
Copy link
Member

@mconnew could you rebase against latest. I got on the server and saw that the web.config of the service being used does not include the most recent endpoints that were added for at least two of the failing tests.

@mconnew mconnew force-pushed the PortVertificateTimeFixToMaster branch from b730e72 to 58b5596 Compare November 30, 2018 21:48
@StephenBonikowsky
Copy link
Member

All good now, merging.

@StephenBonikowsky StephenBonikowsky merged commit afb5f7c into dotnet:master Nov 30, 2018
@mconnew mconnew deleted the PortVertificateTimeFixToMaster branch September 27, 2019 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants