Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix xUnit warning #2000 for wcf test projects. #4019

Merged
merged 1 commit into from
Nov 4, 2019
Merged

Fix xUnit warning #2000 for wcf test projects. #4019

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...rivate.ServiceModel/tests/Scenarios/Binding/Custom/Binding.Custom.IntegrationTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<IsPackable>false</IsPackable>
<!--[todo:arcade] Re-enable these warnings and fix them.-->
<!-- https://xunit.github.io/xunit.analyzers/rules/ -->
<NoWarn>$(NoWarn);xUnit2000;xUnit2009</NoWarn>
<NoWarn>$(NoWarn);xUnit2009</NoWarn>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion ...em.Private.ServiceModel/tests/Scenarios/Binding/Http/Binding.Http.IntegrationTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<IsPackable>false</IsPackable>
<!--[todo:arcade] Re-enable these warnings and fix them.-->
<!-- https://xunit.github.io/xunit.analyzers/rules/ -->
<NoWarn>$(NoWarn);xUnit2000;xUnit2009</NoWarn>
<NoWarn>$(NoWarn);xUnit2009</NoWarn>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion ...stem.Private.ServiceModel/tests/Scenarios/Binding/Tcp/Binding.Tcp.IntegrationTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<IsPackable>false</IsPackable>
<!--[todo:arcade] Re-enable these warnings and fix them.-->
<!-- https://xunit.github.io/xunit.analyzers/rules/ -->
<NoWarn>$(NoWarn);xUnit2000;xUnit2009</NoWarn>
<NoWarn>$(NoWarn);xUnit2009</NoWarn>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion ...dentialSecurity/Binding.WS.TransportWithMessageCredentialSecurity.IntegrationTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<IsPackable>false</IsPackable>
<!--[todo:arcade] Re-enable these warnings and fix them.-->
<!-- https://xunit.github.io/xunit.analyzers/rules/ -->
<NoWarn>$(NoWarn);xUnit2000;xUnit2009</NoWarn>
<NoWarn>$(NoWarn);xUnit2009</NoWarn>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion ...viceModel/tests/Scenarios/Client/ChannelLayer/Client.ChannelLayer.IntegrationTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<IsPackable>false</IsPackable>
<!--[todo:arcade] Re-enable these warnings and fix them.-->
<!-- https://xunit.github.io/xunit.analyzers/rules/ -->
<NoWarn>$(NoWarn);xUnit2000;xUnit2009</NoWarn>
<NoWarn>$(NoWarn);xUnit2009</NoWarn>
</PropertyGroup>

<PropertyGroup>
Expand Down
2 changes: 1 addition & 1 deletion ....ServiceModel/tests/Scenarios/Client/ClientBase/Client.ClientBase.IntegrationTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<IsPackable>false</IsPackable>
<!--[todo:arcade] Re-enable these warnings and fix them.-->
<!-- https://xunit.github.io/xunit.analyzers/rules/ -->
<NoWarn>$(NoWarn);xUnit2000;xUnit2009</NoWarn>
<NoWarn>$(NoWarn);xUnit2009</NoWarn>
</PropertyGroup>

<PropertyGroup>
Expand Down
14 changes: 7 additions & 7 deletions src/System.Private.ServiceModel/tests/Scenarios/Client/ClientBase/SessionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ public static void NonTerminatingMethodCallingDuplexCallbacksNoReentrantCalls()
callsToNonTerminatingMethodToMakeInsideClientCallback: 0,
callsToTerminatingMethodToMakeInsideClientCallback: 0);

Assert.Equal(result, 3);
Assert.Equal(3, result);

ResultsVerificationHelper<Exception>(canMakeServiceCall: true, cbClosedCalled: false, cbClosingCalled: false, cbFaultedCalled: false);
}
Expand All @@ -329,7 +329,7 @@ public static void NonTerminatingMethodCallingDuplexCallbacksCallingService()
callsToNonTerminatingMethodToMakeInsideClientCallback: 2, // + 2 * 2
callsToTerminatingMethodToMakeInsideClientCallback: 0);

Assert.Equal(result, 7);
Assert.Equal(7, result);

ResultsVerificationHelper<Exception>(canMakeServiceCall: true, cbClosedCalled: false, cbClosingCalled: false, cbFaultedCalled: false);
}
Expand All @@ -349,7 +349,7 @@ public static void TerminatingMethodCallingDuplexCallbacksNoReentrantCalls()
callsToNonTerminatingMethodToMakeInsideClientCallback: 0,
callsToTerminatingMethodToMakeInsideClientCallback: 0);

Assert.Equal(result, 3);
Assert.Equal(3, result);

// verify that after this we can not make another call
// note: we really expect ChannelTerminatedException but it is not exposed publically yet
Expand Down Expand Up @@ -377,7 +377,7 @@ public static void TerminatingMethodCallingDuplexCallbacksFailingToCallService()
callsToNonTerminatingMethodToMakeInsideClientCallback: 2, // + 0 as they will fail
callsToTerminatingMethodToMakeInsideClientCallback: 0);

Assert.Equal(result, 3);
Assert.Equal(3, result);

// verify that after this we can not make another call
// note: we really expect ChannelTerminatedException but it is not exposed publically yet
Expand All @@ -401,7 +401,7 @@ public static void NonTerminatingMethodCallingClientSideOnlyTerminatingDuplexCal
callsToNonTerminatingMethodToMakeInsideClientCallback: 0,
callsToTerminatingMethodToMakeInsideClientCallback: 0);

Assert.Equal(result, 2);
Assert.Equal(2, result);

// even though the server can't call any callbacks anymore we can still call the service
ResultsVerificationHelper<Exception>(canMakeServiceCall: true, cbClosedCalled: false, cbClosingCalled: false, cbFaultedCalled: false);
Expand All @@ -424,7 +424,7 @@ public static void NonTerminatingMethodCallingClientSideTerminatingDuplexCallbac
callsToNonTerminatingMethodToMakeInsideClientCallback: 2, // + 2 (not 2*2)
callsToTerminatingMethodToMakeInsideClientCallback: 0);

Assert.Equal(result, 4);
Assert.Equal(4, result);

// even though the server can't call any callbacks anymore we can still call the server
ResultsVerificationHelper<Exception>(canMakeServiceCall: true, cbClosedCalled: false, cbClosingCalled: false, cbFaultedCalled: false);
Expand Down Expand Up @@ -540,7 +540,7 @@ private static void ResultsVerificationHelper<ExpectedException>(bool canMakeSer
if (canMakeServiceCall)
{
var result2 = s_channel.NonTerminatingMethod();
Assert.Equal(result2, 1);
Assert.Equal(1, result2);
}
else
{
Expand Down
2 changes: 1 addition & 1 deletion ...sts/Scenarios/Client/ExpectedExceptions/Client.ExpectedExceptions.IntegrationTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<IsPackable>false</IsPackable>
<!--[todo:arcade] Re-enable these warnings and fix them.-->
<!-- https://xunit.github.io/xunit.analyzers/rules/ -->
<NoWarn>$(NoWarn);xUnit2000;xUnit2009</NoWarn>
<NoWarn>$(NoWarn);xUnit2009</NoWarn>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion ...erviceModel/tests/Scenarios/Client/TypedClient/Client.TypedClient.IntegrationTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<IsPackable>false</IsPackable>
<!--[todo:arcade] Re-enable these warnings and fix them.-->
<!-- https://xunit.github.io/xunit.analyzers/rules/ -->
<NoWarn>$(NoWarn);xUnit2000;xUnit2009;xUnit1024</NoWarn>
<NoWarn>$(NoWarn);xUnit2009;xUnit1024</NoWarn>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion ....Private.ServiceModel/tests/Scenarios/Contract/Data/Contract.Data.IntegrationTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<IsPackable>false</IsPackable>
<!--[todo:arcade] Re-enable these warnings and fix them.-->
<!-- https://xunit.github.io/xunit.analyzers/rules/ -->
<NoWarn>$(NoWarn);xUnit2000;xUnit2009;xUnit2013</NoWarn>
<NoWarn>$(NoWarn);xUnit2009;xUnit2013</NoWarn>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion ...rivate.ServiceModel/tests/Scenarios/Contract/Fault/Contract.Fault.IntegrationTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<IsPackable>false</IsPackable>
<!--[todo:arcade] Re-enable these warnings and fix them.-->
<!-- https://xunit.github.io/xunit.analyzers/rules/ -->
<NoWarn>$(NoWarn);xUnit2000;xUnit2009</NoWarn>
<NoWarn>$(NoWarn);xUnit2009</NoWarn>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion ...te.ServiceModel/tests/Scenarios/Contract/Message/Contract.Message.IntegrationTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<IsPackable>false</IsPackable>
<!--[todo:arcade] Re-enable these warnings and fix them.-->
<!-- https://xunit.github.io/xunit.analyzers/rules/ -->
<NoWarn>$(NoWarn);xUnit2000;xUnit2009</NoWarn>
<NoWarn>$(NoWarn);xUnit2009</NoWarn>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion ...te.ServiceModel/tests/Scenarios/Contract/Service/Contract.Service.IntegrationTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<IsPackable>false</IsPackable>
<!--[todo:arcade] Re-enable these warnings and fix them.-->
<!-- https://xunit.github.io/xunit.analyzers/rules/ -->
<NoWarn>$(NoWarn);xUnit2000;xUnit2009</NoWarn>
<NoWarn>$(NoWarn);xUnit2009</NoWarn>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion ...del/tests/Scenarios/Contract/XmlSerializer/Contract.XmlSerializer.IntegrationTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<IsPackable>false</IsPackable>
<!--[todo:arcade] Re-enable these warnings and fix them.-->
<!-- https://xunit.github.io/xunit.analyzers/rules/ -->
<NoWarn>$(NoWarn);xUnit2000;xUnit2009</NoWarn>
<NoWarn>$(NoWarn);xUnit2009</NoWarn>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion ....ServiceModel/tests/Scenarios/Encoding/Encoders/Encoding.Encoders.IntegrationTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<IsPackable>false</IsPackable>
<!--[todo:arcade] Re-enable these warnings and fix them.-->
<!-- https://xunit.github.io/xunit.analyzers/rules/ -->
<NoWarn>$(NoWarn);xUnit2000;xUnit2009;xUnit1024</NoWarn>
<NoWarn>$(NoWarn);xUnit2009;xUnit1024</NoWarn>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion ...l/tests/Scenarios/Encoding/MessageVersion/Encoding.MessageVersion.IntegrationTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<IsPackable>false</IsPackable>
<!--[todo:arcade] Re-enable these warnings and fix them.-->
<!-- https://xunit.github.io/xunit.analyzers/rules/ -->
<NoWarn>$(NoWarn);xUnit2000;xUnit2009;xUnit1024</NoWarn>
<NoWarn>$(NoWarn);xUnit2009;xUnit1024</NoWarn>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion ...enarios/Extensibility/MessageEncoder/Extensibility.MessageEncoder.IntegrationTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<IsPackable>false</IsPackable>
<!--[todo:arcade] Re-enable these warnings and fix them.-->
<!-- https://xunit.github.io/xunit.analyzers/rules/ -->
<NoWarn>$(NoWarn);xUnit2000;xUnit2009</NoWarn>
<NoWarn>$(NoWarn);xUnit2009</NoWarn>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion ...Extensibility/MessageInterceptor/Extensibility.MessageInterceptor.IntegrationTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<IsPackable>false</IsPackable>
<!--[todo:arcade] Re-enable these warnings and fix them.-->
<!-- https://xunit.github.io/xunit.analyzers/rules/ -->
<NoWarn>$(NoWarn);xUnit2000;xUnit2009</NoWarn>
<NoWarn>$(NoWarn);xUnit2009</NoWarn>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion ...tests/Scenarios/Extensibility/WebSockets/Extensibility.WebSockets.IntegrationTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<IsPackable>false</IsPackable>
<!--[todo:arcade] Re-enable these warnings and fix them.-->
<!-- https://xunit.github.io/xunit.analyzers/rules/ -->
<NoWarn>$(NoWarn);xUnit2000;xUnit2009</NoWarn>
<NoWarn>$(NoWarn);xUnit2009</NoWarn>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion ...rivate.ServiceModel/tests/Scenarios/Infrastructure/Infrastructure.IntegrationTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<IsPackable>false</IsPackable>
<!--[todo:arcade] Re-enable these warnings and fix them.-->
<!-- https://xunit.github.io/xunit.analyzers/rules/ -->
<NoWarn>$(NoWarn);xUnit2000;xUnit2009</NoWarn>
<NoWarn>$(NoWarn);xUnit2009</NoWarn>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion ...s/Scenarios/Security/TransportSecurity/Security.TransportSecurity.IntegrationTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<IsPackable>false</IsPackable>
<!--[todo:arcade] Re-enable these warnings and fix them.-->
<!-- https://xunit.github.io/xunit.analyzers/rules/ -->
<NoWarn>$(NoWarn);xUnit2000;xUnit2009</NoWarn>
<NoWarn>$(NoWarn);xUnit2009</NoWarn>
</PropertyGroup>

<PropertyGroup>
Expand Down