Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NullReferenceException when using BasicHttpBinding and NTLM web proxy authentication #4555

Merged
merged 4 commits into from
Mar 22, 2021
Merged

Fix NullReferenceException when using BasicHttpBinding and NTLM web proxy authentication #4555

merged 4 commits into from
Mar 22, 2021

Conversation

fondencn
Copy link

@fondencn fondencn commented Mar 4, 2021

Fixed Check for SecurityTokenManager initialization for web proxies with NTLM authentication:
When using BasicHttpClient Bindings with additional authentication for enterprise style web proxies, a NullReferenceException was raised because of missing initialization of SecurityTokenManager (resulting member field was NULL).

By extracting the AuthenticationScheme passed by the used binding and using it for deciding whether SecurityTokenManager is needed or not, the NRE is removed and NTLM auth can be used successfully within the HTTP channel factory.

…th NTLM authentication and BasicHttpBinding
@fondencn
Copy link
Author

fondencn commented Mar 4, 2021

Team-Internal review needed first

@fondencn fondencn marked this pull request as draft March 4, 2021 22:23
@fondencn
Copy link
Author

fondencn commented Mar 9, 2021

Created issue #4557 for this PullRequest

@fondencn fondencn marked this pull request as ready for review March 9, 2021 07:28
@HongGit HongGit requested a review from mconnew March 9, 2021 23:29
@dnfadmin
Copy link

dnfadmin commented Mar 10, 2021

CLA assistant check
All CLA requirements met.

@mconnew
Copy link
Member

mconnew commented Mar 10, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@fondencn
Copy link
Author

@mconnew Will this PR be accepted/merged soon? Not sure about how this works in the dotnet/wcf project... Am I still missing something? There is still a discussion and another PR in issue #4557 with another fix proposal...

@fondencn fondencn requested a review from mconnew March 16, 2021 09:40
@mconnew mconnew merged commit b0f8d0d into dotnet:main Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants