Fix unhandled KeyNotFoundException in RequestReplyCorrelator #4743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenMolloy
approved these changes
Oct 15, 2021
| @@ -45,13 +44,12 @@ T IRequestReplyCorrelator.Find<T>(Message reply, bool remove) | |||
| UniqueId relatesTo = GetRelatesTo(reply); | |||
| Type stateType = typeof(T); | |||
| Key key = new Key(relatesTo, stateType); | |||
| T value; | |||
| T value = (T)_states[key]; | |||
There was a problem hiding this comment.
Seems like this would have been a potential issue before, but Dictionary would throw here if the key wasn't found, resulting in an exception here instead of returning null. Unless that was the intent of this method. In which case, Hashtable doesn't do that.
There was a problem hiding this comment.
That's exactly the issue I'm fixing 😄. On NetFx it uses Hashtable. The change to Dictionary caused an uncaught exception thrown right here.
There was a problem hiding this comment.
It's right there in the title and everything. Doh! 🤦♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4301