Use SDK's version for restoring NetFx targeting pack #5233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We don't use the Shim package any more. With moving the implementation into the actual packages rather than it all being in System.Private.ServiceModel, we got a circular dependency problem when trying to build the Shim. Unless you have the time and will to make it work again, we should remove the Shim package project. |
|
I'll sync offline with you on that. Unsure I understood you correctly. |
|
@mconnew I now see what you mean and just deleted the project. PTAL |
mconnew
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SDK exposes the current version of the .NET Framework targeting pack to restore: https://github.com/dotnet/sdk/blob/25c6d1202b73a07f7932c61262131ee08509ca0e/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.props#L123C3-L123C3
Avoid the hardcoded version and use the SDK one instead.