-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test failure System.Drawing.Tests.GraphicsTests #8829
Comments
Tagging subscribers to this area: @safern, @tarekgh Issue DetailsRun: runtime-coreclr libraries-jitstress 20210411.1 Failed tests:
Error message:
|
Failed again in runtime-coreclr libraries-jitstressregs 20210622.1 Failed tests:
Error message:
|
Failed again in runtime 20210721.8 Failed test:
Error message:
|
This started showing up a lot in rolling builds for ARM64 windows on CoreCLR https://runfo.azurewebsites.net/search/tests/?q=started%3A%7E7+definition%3Aruntime+name%3ASystem.Drawing.Tests.GraphicsTests |
How do you get that graph @hoyosjs ? Is it a runfo thing? |
This one is from AzDO analytics view. Ones with more detail can give extracted from |
Listo? |
Kusto* (autocorrect in Spanish+English does some interesting guesses) |
I see another set of these failures here: |
I'll disable the test for now. |
Failed again in runtime 20210801.17 Failed test:
Error message:
|
It only ever fails for Windows 10 Arm64 They fail on either 3186 or 3179 with Assert.False failing. Only one of those have an Assert.False, not sure what the other means tests are doing @JeremyKuhne , is the GDI+ clipping region specific to the window itself, or to the HWND/HDC we wrapped with the Graphics object? If the latter then it's a puzzle since we don't set a clipping region. If the former, does it suggest eg during the test the foreground window was obscured or minimized? |
@danmoseley if the DC that it is created around is fully obscured this could happen. Checking the foreground window without actually looking at the clip seems problematic. :) |
What does it mean for a foreground window to be obscured- it's located off the visible screen? Is there something simple I could do here to ensure it's not clipped? |
Something is over top of it, it is off screen, etc. I'd try just grabbing the desktop DC. Here is how I was experimenting with this: https://github.com/JeremyKuhne/WInterop/blob/main/src/Tests/WInterop.Tests/GdiPlus/ClippingTests.cs |
Thanks for the snippet. OK, up for grabs for someone to fix the test to do this. |
Happened again in dotnet/runtime#57785. Build https://dev.azure.com/dnceng/public/_build/results?buildId=1333217&view=ms.vss-test-web.build-test-results-tab&runId=39101282&resultId=126891&paneView=debug.
|
Happened again on 1833334 (6/19 AM) -- all 5 tests on net7.0-windows-Release-x86-CoreCLR_release-Windows.7.Amd64.Open Looking at Runfo, there have been 82 failures (12 failures are on Rolling runs) of all 5 tests on the same platform in last 7 days:
@dotnet/area-system-drawing can you please disable the test also on Win7 x86? Note: Looks like it started regressing 4 days ago on 6/16 |
Related: https://github.com/dotnet/runtime/issues/51097. Disables the failing tests on Windows 7 as well.
* Disable failing graphics tests on windows 7 Related: https://github.com/dotnet/runtime/issues/51097. Disables the failing tests on Windows 7 as well.
* Disable failing graphics tests on windows 7 Related: https://github.com/dotnet/runtime/issues/51097. Disables the failing tests on Windows 7 as well. Commit migrated from dotnet/runtime@879f201
Seen on 2023/01/09 in an unrelated
|
Run: runtime-coreclr libraries-jitstress 20210411.1
Failed tests:
Error message:
Runfo Tracking Issue: system.drawing.tests.graphicstests.fromhdc_validhdcwithcontext_returnsexpected
Build Result Summary
The text was updated successfully, but these errors were encountered: