Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change hosted pool #57785

Merged
merged 3 commits into from
Nov 4, 2021
Merged

Change hosted pool #57785

merged 3 commits into from
Nov 4, 2021

Conversation

ulisesh
Copy link
Contributor

@ulisesh ulisesh commented Aug 19, 2021

We have a new set of AzDo pools where we eventually will move all servicing work, this PR tests Build.Ubuntu.1804.Amd64.Open

@ghost
Copy link

ghost commented Aug 19, 2021

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

We have a new set of AzDo pools where we eventually will move all servicing work, this PR tests Build.Ubuntu.1804.Amd64.Open

Author: ulisesh
Assignees: -
Labels:

area-Infrastructure-libraries
Milestone: -

@ulisesh ulisesh requested a review from safern August 20, 2021 18:56
ViktorHofer
ViktorHofer reviewed Sep 1, 2021
View reviewed changes
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you are mentioning "testing" in the PR description, do you want this to get merged or is the PR just testing the pools?

@ulisesh
Copy link
Contributor Author

ulisesh commented Sep 1, 2021

As you are mentioning "testing" in the PR description, do you want this to get merged or is the PR just testing the pools?

I want to merge it :)

MattGal
MattGal approved these changes Sep 1, 2021
View reviewed changes
Copy link
Member

@MattGal MattGal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks valid, I'd merge if it passes your builds. (Edit; it did and the only test failures are that xunit thing and system.drawing on Arm64 which is very unlikely to be related)

@ulisesh
Copy link
Contributor Author

ulisesh commented Sep 1, 2021

looks valid, I'd merge if it passes your builds. (Edit; it did and the only test failures are that xunit thing and system.drawing on Arm64 which is very unlikely to be related)

Agree, I don't think Arm64 test failures are related to this change. @ViktorHofer, who is a good person to merge this? It looks like a don't have enough permissions

@ViktorHofer ViktorHofer mentioned this pull request Sep 1, 2021
Open
@ulisesh ulisesh mentioned this pull request Sep 1, 2021
Merged
@ViktorHofer
Copy link
Member

Issues are:

@ViktorHofer
Copy link
Member

Oh just before merging noticed that this targets release/5.0. @Anipik can we merge the PR or is the branch closed?

@ulisesh
Copy link
Contributor Author

ulisesh commented Sep 1, 2021

This pools are specific for Servicing work in release branches

@ulisesh
Copy link
Contributor Author

ulisesh commented Sep 2, 2021

@ViktorHofer can you please help us merge this PR too? It is the same change we did in #58484

@ViktorHofer
Copy link
Member

I don't manage the servicing branches. Ping @Anipik for my question above.

@Anipik
Copy link
Contributor

Anipik commented Sep 3, 2021

The branch is currently closed. i will merge this one when the branch will open for the next servicing release

@ericstj ericstj assigned ulisesh and Anipik and unassigned ulisesh Sep 27, 2021
@ericstj
Copy link
Member

ericstj commented Sep 27, 2021

@Anipik is this ready to go yet?

@Anipik Anipik added the Servicing-approved Approved for servicing release label Oct 25, 2021
@Anipik
Copy link
Contributor

Anipik commented Oct 25, 2021

adding servicing approved so i dont miss this one for the next release

@Anipik Anipik merged commit 7b19c71 into dotnet:release/5.0 Nov 4, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Dec 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ViktorHofer ViktorHofer ViktorHofer left review comments

@safern safern safern approved these changes

@MattGal MattGal MattGal approved these changes

@Anipik Anipik Awaiting requested review from Anipik

Assignees

@Anipik Anipik

Labels
area-Infrastructure-libraries Servicing-approved Approved for servicing release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ulisesh @ViktorHofer @Anipik @ericstj @MattGal @safern