Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change locks to System.Threading.Lock #11841

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

JeremyKuhne
Copy link
Member

@JeremyKuhne JeremyKuhne commented Aug 8, 2024

Change internal lock objects to System.Threading.Lock

Fixes #11672

Microsoft Reviewers: Open in CodeFlow

Change internal lock objects to System.Threading.Lock

Fixes dotnet#11672
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit: Minor comment, but can be addressed in the next.

@JeremyKuhne JeremyKuhne enabled auto-merge (squash) August 8, 2024 18:39
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 83.63636% with 9 lines in your changes missing coverage. Please review.

Project coverage is 75.00413%. Comparing base (7aeab49) to head (baad52b).
Report is 44 commits behind head on feature/10.0.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           feature/10.0      #11841         +/-   ##
======================================================
- Coverage      75.30464%   75.00413%   -0.30052%     
======================================================
  Files              3039        3035          -4     
  Lines            645429      630232      -15197     
  Branches          50777       46683       -4094     
======================================================
- Hits             486038      472700      -13338     
+ Misses           155909      154187       -1722     
+ Partials           3482        3345        -137     
Flag Coverage Δ
Debug 75.00413% <83.63636%> (-0.30052%) ⬇️
integration 17.95314% <62.26415%> (-1.50399%) ⬇️
production 48.11162% <84.90566%> (-1.38449%) ⬇️
test 97.01069% <50.00000%> (-0.04806%) ⬇️
unit 45.13556% <81.13208%> (-1.36739%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@JeremyKuhne JeremyKuhne merged commit de9af8f into dotnet:feature/10.0 Aug 8, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants