Remove STA thread affinitisation (servicing) #5953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Application bootstrap was designed and built before the file-scope namespaces became a thing, and supported a) the original namespace declarations, and b) the new top level statements declarations. In the case of top level statements there is no `Main()` method on to which a developer can apply `STAThreadAttribute`, and to accommodate this use case we added explicit STA thread affinitisation. The same code gets emitted for file-scope namespace declarations, which is undesirable, as it has overhead and perf implications. Whilst the top level statements are supported in Windows Forms, those don't represent the main use case, and any developer who wishes to use top level statements in Program.cs can write STA thread affinitisation statements by hand.
RussKie
added
tenet-performance
This comment has been minimized.
This comment has been minimized.
|
Any issue associated with this for the background? |
This comment has been minimized.
This comment has been minimized.
leecow
added
Servicing-approved
I discovered this myself during exploratory testing of the the new feature.
Please let me know if you have any questions. |
dreddy-work
approved these changes
Oct 13, 2021
dreddy-work
added
the
ready-to-merge
|
@Olina-Zhang please add this into a verification runsheet. Thank you. |
RussKie
removed
the
ready-to-merge
Will add it to regular checking. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Application bootstrap was designed and built before the file-scope namespaces became a thing, and supported
a) the original namespace declarations, and
b) the new top level statements declarations.
In the case of top level statements there is no
Main()method on to which a developer can applySTAThreadAttribute, and to accommodate this use case we added explicit STA thread affinitisation.The same code gets emitted for file-scope namespace declarations, which is undesirable, as it has overhead and perf implications.
Whilst the top level statements are supported in Windows Forms, those don't represent the main use case, and any developer who wishes to use top level statements in Program.cs can write STA thread affinitisation statements by hand.
Customer Impact
Regression?
Application.Initialize()is a new feature in .NET 6.0Risk
Microsoft Reviewers: Open in CodeFlow