Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix create BitmapDecoder with async file stream. #4966

Merged
merged 2 commits into from
Aug 12, 2022

Conversation

lindexi
Copy link
Member

@lindexi lindexi commented Aug 2, 2021

Fixes Issue #4355

Description

Fix #4355

Customer Impact

Regression

Testing

Just CI and my demo: https://github.com/lindexi/lindexi_gd/tree/20b78c5547b2ecacdd244a438ef58518469a91d7/GeafakaijawkeheahemLejeehocear

Risk

[BitmapDecoder.Create does not handle FileStream with FileOptions.Asynchronous · Issue dotnet#4355 · dotnet/wpf](dotnet#4355 )
@lindexi lindexi requested a review from a team as a code owner August 2, 2021 00:39
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Aug 2, 2021
@ghost ghost requested review from fabiant3, ryalanms and SamBent August 2, 2021 00:39
lindexi added a commit to lindexi/UWP that referenced this pull request Aug 2, 2021
lindexi added a commit to lindexi/lindexi_gd that referenced this pull request Aug 2, 2021
@lindexi
Copy link
Member Author

lindexi commented Dec 21, 2021

Ping @vishalmsft

@vishalmsft
Copy link
Contributor

vishalmsft commented Dec 21, 2021

Thank you @lindexi for the PR. The fix looks to work, as discussed in the relevant issue.
Can you please also submit a Test case at wpf-test

Please let me know, if you need any help with adding the test there. It is just about adding one new WPF project and then adding the executable entry in the xml file.
In case more help is needed, feel free to create one discussion \ Q&A entry.

@lindexi
Copy link
Member Author

lindexi commented Dec 26, 2021

@vishalmsft Thank you. And I added the Test case in dotnet/wpf-test#14

But I need your help reviewing my test code.

@dipeshmsft
Copy link
Member

We have taken this PR for the current Community Test Pass. Thanks for the contribution.

@lindexi
Copy link
Member Author

lindexi commented Aug 11, 2022

Thank you @dipeshmsft

And can you review my test PR: dotnet/wpf-test#14

@dipeshmsft
Copy link
Member

Regarding the test PR, we would have to wait for a little. The test may need to be in a different area ( the tests are divided into areas and subareas ), so once, we have all the areas there ( only a few DRTs are remaining ), we will have a discussion on that and go ahead with the test PR.

@dipeshmsft dipeshmsft merged commit fa202b6 into dotnet:main Aug 12, 2022
@lindexi
Copy link
Member Author

lindexi commented Aug 12, 2022

Thank you @dipeshmsft

@ghost ghost locked as resolved and limited conversation to collaborators Sep 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Community Contribution A label for all community Contributions PR metadata: Label to tag PRs, to facilitate with triage
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

BitmapDecoder.Create does not handle FileStream with FileOptions.Asynchronous
4 participants