Fix GetStreamCore in ContentFilePart #5066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Application.ResourceAssembly.CodeBase is the string without escaped. See: - dotnet#4781 - dotnet#5004 - dotnet#4799
ghost
requested review from
src/Microsoft.DotNet.Wpf/src/PresentationFramework/MS/Internal/AppModel/ContentFilePart.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.Wpf/src/PresentationFramework/MS/Internal/AppModel/ContentFilePart.cs
Outdated
Show resolved
Hide resolved
lindexi
added a commit
to dotnet-campus/wpf-test
that referenced
this pull request
Jan 29, 2022
pchaurasia14
added
the
Community Contribution
karelz
approved these changes
Aug 30, 2022
|
Thank you @karelz |
dipeshmsft
approved these changes
Sep 1, 2022
|
@lindexi, thanks for the contribution. We can go ahead and close the referenced issues. |
singhashish-wpf
pushed a commit
that referenced
this pull request
Nov 1, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #4781 #4987
Main PR
Description
The Application.ResourceAssembly.CodeBase is the string without escaped.
See:
Customer Impact
See #4781
Regression
Testing
Just CI and my demo code.
The test package: https://www.nuget.org/packages/Lindexi.Src.CustomWPF/1.0.6
The test demo: https://github.com/lindexi/lindexi_gd/tree/5f274174e8fd12fe6f4738c0e4605b22a3252901/WhejohafaChalehelair
Risk
Low.