Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include d3dcompiler_47.dll on ARM64. #5747

Merged
merged 1 commit into from
Dec 16, 2021
Merged

Don't include d3dcompiler_47.dll on ARM64. #5747

merged 1 commit into from
Dec 16, 2021

Conversation

singhashish-wpf
Copy link
Member

Fixes Issue
#5462
Main PR
None

Description

Don't include d3dcompiler_47.dll on ARM64.

Customer Impact

Without this change the d3dcompiler.dll which is shipped for arm64 is causing issues with 3rd party libraries.
In some cases when starting the application, the chromium browser hangs, and the log file contains an error that it cannot find the D3DCompile entry point

Regression

No

Testing

Build and CI

Risk

None

@singhashish-wpf singhashish-wpf requested a review from a team as a code owner November 29, 2021 12:39
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Nov 29, 2021
@ghost ghost requested review from fabiant3, ryalanms and SamBent November 29, 2021 12:39
@singhashish-wpf singhashish-wpf merged commit a80b76e into dotnet:main Dec 16, 2021
@singhashish-wpf singhashish-wpf deleted the d3dcompiler branch December 16, 2021 07:10
@hamarb123
Copy link

I'm having issues with this on my app. Can this be back-ported to .NET 6.0.4? I'm going to wait until next LTS for upgrade so I would be stuck not being able to support arm64 users until .NET 8 (~1.5 years).

@lindexi
Copy link
Member

lindexi commented Mar 22, 2022

@singhashish-wpf Can we cherry-pick this to dotnet 6 ? Can it work in dotnet 6?

@ghost ghost locked as resolved and limited conversation to collaborators Apr 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants