Avoid Hashtable-related allocations in DataBindEngine #6501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
ghost
requested review from
halgab
reviewed
May 3, 2022
src/Microsoft.DotNet.Wpf/src/PresentationFramework/MS/Internal/Data/DataBindEngine.cs
Outdated
Show resolved
Hide resolved
The _valueConverterTable is a Hashtable that uses a struct-based key. It's boxing every time a lookup is performed or an add is performed.
stephentoub
force-pushed
the
valuetableconverteralloc
branch
from
e1618c7
to
334bfb2
Compare
dipeshmsft
approved these changes
Aug 5, 2022
|
We have taken this PR for the current Community Test Pass. Thanks for the contribution. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The _valueConverterTable is a Hashtable that uses a struct-based key. It's boxing every time a lookup is performed or an add is performed.
Customer Impact
Unnecessary allocation
Regression
No
Testing
CI
Risk
Minimal
Microsoft Reviewers: Open in CodeFlow