Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid delegate allocation to call ListCollectionView.PrepareComparer #6511

Merged
merged 1 commit into from
Jul 21, 2022

Conversation

stephentoub
Copy link
Member

@stephentoub stephentoub commented May 1, 2022

Description

Pass the required state in as a state object to be passed on to the delegate invocation.

Customer Impact

Unnecessary allocation

Regression

No

Testing

CI

Risk

Minimal

Microsoft Reviewers: Open in CodeFlow

Pass the required state is a a static object to be passed on to the delegate invocation.
@stephentoub stephentoub requested a review from a team as a code owner May 1, 2022 02:44
@ghost ghost assigned stephentoub May 1, 2022
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label May 1, 2022
@ghost ghost requested review from dipeshmsft, singhashish-wpf and SamBent May 1, 2022 02:44
@singhashish-wpf singhashish-wpf merged commit c8742b5 into dotnet:main Jul 21, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants