Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Brotli compression #55

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bstordrup
Copy link

Adding support for Brotli compressio.

Fixes #54

@bstordrup
Copy link
Author

Unfortunately, I don't have a pcap file containing Brotli encoded material, so I'm not able to provide unit test for this.

@chmorgan
Copy link
Collaborator

chmorgan commented Feb 4, 2023

Hi @bstordrup, how do we know this is the right approach for decoding this compression? I think we would need a test stream, even if it was a pcap stream from somewhere else that we could use here. Thoughts on where we might get one?

@bstordrup
Copy link
Author

@chmorgan, I know of a page that supports compressing the result with Brotli. I can see if I can capture something from it with Wireshark.

@bstordrup
Copy link
Author

Added a pcap file that contains a HTTP GET request to an REST API project and returns a brotli compressed response in form of a Json file.

And added a unit test that evaluates this pcap file in the same way as handling the gziped contents pcap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Brottli compression
2 participants