Pin Numpy: numpy<2.0.0, Prevent ModuleNotFoundError
#977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Major revision bumps (1.x.x -> 2.x.x) always have breaking changes. Should the other requirements not be limited in this way as well? That would have to wait, though. This issue affects all scripts and modules that import outlines, and should be merged ASAP. |
Good idea, I created an issue for that #981 |
|
Hi @rlouf, could you please make a new release? vLLM imports outlines for the OpenAI server and is currently broken because of this Numpy issue. |
|
Will do right now |
|
@rlouf Thanks a lot!! |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #976
Fixes vllm-project/vllm#5582
We should close 976 after we fix Outlines to be compatible with Numpy >= 2.0.0, which this PR doesn't do.
Problem
Cannot
import outlinesdue tooutlines/base.pyimportingfrom numpy.lib.function_base import (which no longer exists in numpy 2.0.0.Temporary Solution
Pin
numpy<2.0.0