Fix caching issue caused by incorrect isProvisional check

A static TypeRef can still be provisional if it's currently being completed (see the logic in `Namer#TypeDefCompleter#typeSig`). Fixes scala#16950.
dotty-staging · Apr 13, 2023 · f0f6baf · f0f6baf
1 parent aecbfa7
commit f0f6baf
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/compiler/src/dotty/tools/dotc/core/Types.scala b/compiler/src/dotty/tools/dotc/core/Types.scala
@@ -118,10 +118,9 @@ object Types {
         if t.mightBeProvisional then
           t.mightBeProvisional = t match
             case t: TypeRef =>
-              !t.currentSymbol.isStatic && {
+              t.currentSymbol.isProvisional || !t.currentSymbol.isStatic && {
                 (t: Type).mightBeProvisional = false // break cycles
-                t.symbol.isProvisional
-                || test(t.prefix, theAcc)
+                test(t.prefix, theAcc)
                 || t.denot.infoOrCompleter.match
                     case info: LazyType => true
                     case info: AliasingBounds => test(info.alias, theAcc)

diff --git a/tests/pos/i16950.scala b/tests/pos/i16950.scala
@@ -0,0 +1,11 @@
+object Foo:
+  def bar(x : Bar.YOf[Any]): Unit = ???
+
+trait K:
+  type CType <: Bar.YOf[Any]
+  def foo : K =
+    val x : CType = ???
+    x // was: error: Found: CType, Expected: K
+
+object Bar:
+  type YOf[T] = K { type M }