Skip to content

Commit

Permalink
[YUNIKORN-2091] Remove last remnants of Application CRD (apache#710)
Browse files Browse the repository at this point in the history
Closes: apache#710
  • Loading branch information
craigcondit committed Oct 31, 2023
1 parent 6a30d08 commit b1e44a5
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 9 deletions.
3 changes: 0 additions & 3 deletions deployments/scheduler/yunikorn-rbac.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,6 @@ rules:
- apiGroups: [""]
resources: ["pods"]
verbs: ["get", "watch", "list", "create", "patch", "update", "delete"]
- apiGroups: ["yunikorn.apache.org"]
resources: ["*"]
verbs: ["*"]
- apiGroups: ["sparkoperator.k8s.io"]
resources: ["*"]
verbs: ["*"]
Expand Down
4 changes: 1 addition & 3 deletions pkg/appmgmt/interfaces/appmgr.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,7 @@ type AppManager interface {
// this will be called before starting the service.
ServiceInit() error

// if the service has some internal stuff to run, this is the place to run them
// usually if an application is defined as K8s CRD, the operator service needs
// to watch on these CRD events. the CRD informers can be launched here.
// if the service has some internal stuff to run, this is the place to run them.
// some implementation may not need to implement this.
Start() error

Expand Down
3 changes: 0 additions & 3 deletions pkg/common/constants/constants.go
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,6 @@ const SchedulerName = "yunikorn"
// OwnerReferences
const DaemonSetType = "DaemonSet"

// Application crd
const AppManagerHandlerName = "yunikorn-app"

// Gang scheduling
const PlaceholderContainerImage = "registry.k8s.io/pause:3.7"
const PlaceholderContainerName = "pause"
Expand Down

0 comments on commit b1e44a5

Please sign in to comment.