feat(freecache): v2 finish #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PengYechang
had a problem deploying
to
tablestore-live
GitHub Actions
Failure
PengYechang
temporarily deployed
to
tablestore-live
GitHub Actions
Inactive
sysulq
requested changes
Feb 8, 2023
pkg/cache/xfreecache/v2/config.go
Outdated
| ) | ||
|
|
||
| // DefaultConfig 返回默认配置 缓存容量256MB | ||
| func DefaultConfig() Config { |
pkg/cache/xfreecache/v2/config.go
Outdated
| } | ||
|
|
||
| // SetName 设置缓存名称 | ||
| func (c Config) SetName(name string) Config { |
There was a problem hiding this comment.
这些Set方法可以先去掉，变量已经export出来了，后面有必要再加呢？
| } | ||
|
|
||
| type localStorage struct { | ||
| req Config |
| } | ||
|
|
||
| func Test_cache_GetAndSetCacheData(t *testing.T) { | ||
| oneCache := NewLocalCache[string, Student](DefaultConfig(). |
There was a problem hiding this comment.
有没有可能把API设计为DefaultConfig().Build()? 和其他组件的API保持一致
PengYechang
had a problem deploying
to
tablestore-live
GitHub Actions
Failure
PengYechang
temporarily deployed
to
tablestore-live
GitHub Actions
Inactive
PengYechang
temporarily deployed
to
tablestore-live
GitHub Actions
Inactive
sysulq
requested changes
Feb 8, 2023
|
|
||
| // ParseSize parses a size string. | ||
| // Valid time units are "b" (or "byte"), "kb", "mb", "gb", "tb". | ||
| func ParseSize(s string) (Size, error) { |
There was a problem hiding this comment.
pkg/cache/xfreecache/v2/config.go
Outdated
| func DefaultConfig(size Size) *Config { | ||
| once.Do(func() { | ||
| if size < 512*KB { | ||
| size = 256 * MB |
pkg/cache/xfreecache/v2/config.go
Outdated
| if size < 512*KB { | ||
| size = 256 * MB | ||
| } | ||
| innerCache = freecache.NewCache(int(size)) |
There was a problem hiding this comment.
这个NewCache可以在解析完配置之后再做，DefaultConfig只设置默认配置
pkg/cache/xfreecache/v2/cache.go
Outdated
| if val, ok := v[id]; ok { | ||
| cacheData = val | ||
| } | ||
| data, innerErr := json.Marshal(cacheData) |
There was a problem hiding this comment.
这个是否判断下，如果是proto.Message，就用proto来编解码
There was a problem hiding this comment.
可以加个benchmark对比下proto和json两种对象的性能
PengYechang
temporarily deployed
to
tablestore-live
GitHub Actions
Inactive
PengYechang
temporarily deployed
to
tablestore-live
GitHub Actions
Inactive
PengYechang
temporarily deployed
to
tablestore-live
GitHub Actions
Inactive
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #702 +/- ##
==========================================
- Coverage 53.33% 53.33% -0.01%
==========================================
Files 191 191
Lines 10545 10547 +2
==========================================
+ Hits 5624 5625 +1
Misses 4498 4498
- Partials 423 424 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
PengYechang
temporarily deployed
to
tablestore-live
GitHub Actions
Inactive
sysulq
requested changes
Feb 14, 2023
pkg/cache/xfreecache/v2/cache.go
Outdated
|
|
||
| // id去重 | ||
| ids = lo.Uniq(ids) | ||
| idsNone := make([]K, 0) |
pkg/cache/xfreecache/v2/cache.go
Outdated
| cacheKey := c.getKey(key, id) | ||
| if resT, innerErr := c.GetCacheData(cacheKey); innerErr == nil && resT != nil { | ||
| var value V | ||
| if msg, ok := any(value).(proto.Message); ok { // Constrained to proto.Message |
There was a problem hiding this comment.
可以考虑封装下unmarshal和marshal的方法，参数是any
1、格式化import的路径 2、预分配len(ids)的内存 3、封装unmarshal和marshal方法
PengYechang
temporarily deployed
to
tablestore-live
GitHub Actions
Inactive
miaofeng2027
previously approved these changes
Feb 15, 2023
补充bench test
PengYechang
temporarily deployed
to
tablestore-live
GitHub Actions
Inactive
add sync.Pool
PengYechang
temporarily deployed
to
tablestore-live
GitHub Actions
Inactive
add sync.Pool
PengYechang
temporarily deployed
to
tablestore-live
GitHub Actions
Inactive
change interface{} to any
PengYechang
had a problem deploying
to
tablestore-live
GitHub Actions
Failure
PengYechang
temporarily deployed
to
tablestore-live
GitHub Actions
Inactive
sysulq
approved these changes
Feb 17, 2023
pkg/cache/xfreecache/v2/encode.go
Outdated
| msgType := reflect.TypeOf(msg).Elem() | ||
|
|
||
| // Make a new one, and throw it back into T | ||
| msg = reflect.New(msgType).Interface().(proto.Message) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Does this pull request fix one issue?
Describe how you did it
Describe how to verify it
Special notes for reviews