-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: read config from nacos #838
Conversation
@hnlq715 can help me review the code, tks. |
Thanks for contribution, please pass golangci-lint and add some tests to this nacos implementation. |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #838 +/- ##
==========================================
+ Coverage 52.87% 52.91% +0.04%
==========================================
Files 202 202
Lines 11318 11326 +8
==========================================
+ Hits 5984 5993 +9
+ Misses 4879 4877 -2
- Partials 455 456 +1
|
@hnlq715 has modified, please review again. |
@hnlq715 I saw that this PR was reverted, is there any problem? |
@5idu https://github.com/douyu/jupiter/actions/runs/4921729959/jobs/8791856738 |
Describe what this PR does / why we need it
support read config from nacos datasource.
Does this pull request fix one issue?
Describe how to verify it
go run main.go --config="nacos://ip:port/config.yaml?dataId=mytest&group=xxx&namespaceId=xxx&timeout=10000&accessKey=xxx&secretKey=xxx"