fix(useSelect): correct getLabelProps return type (#1562)

downshift-js · Dec 29, 2023 · a5d6310 · a5d6310
1 parent 53dd723
commit a5d6310
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 20 deletions.
diff --git a/src/hooks/useSelect/__tests__/getLabelProps.test.js b/src/hooks/useSelect/__tests__/getLabelProps.test.js
@@ -1,4 +1,4 @@
-import {act, screen} from '@testing-library/react'
+import {screen} from '@testing-library/react'
 import {renderSelect, renderUseSelect} from '../testUtils'
 import {defaultIds, getToggleButton, user} from '../../testUtils'
 
@@ -53,15 +53,13 @@ describe('getLabelProps', () => {
     const mockToggleButton = {focus: jest.fn()}
     const {result} = renderUseSelect()
 
-    act(() => {
-      const {onClick} = result.current.getLabelProps({
-        onClick: userOnClick,
-      })
-      const {ref} = result.current.getToggleButtonProps()
-      ref(mockToggleButton)
-
-      onClick({})
+    const {onClick} = result.current.getLabelProps({
+      onClick: userOnClick,
     })
+    const {ref} = result.current.getToggleButtonProps()
+    ref(mockToggleButton)
+
+    onClick({})
 
     expect(userOnClick).toHaveBeenCalledTimes(1)
     expect(mockToggleButton.focus).toHaveBeenCalledTimes(1)
@@ -74,15 +72,13 @@ describe('getLabelProps', () => {
     const mockToggleButton = {focus: jest.fn()}
     const {result} = renderUseSelect()
 
-    act(() => {
-      const {onClick} = result.current.getLabelProps({
-        onClick: userOnClick,
-      })
-      const {ref} = result.current.getToggleButtonProps()
-      ref(mockToggleButton)
-
-      onClick({})
+    const {onClick} = result.current.getLabelProps({
+      onClick: userOnClick,
     })
+    const {ref} = result.current.getToggleButtonProps()
+    ref(mockToggleButton)
+
+    onClick({})
 
     expect(userOnClick).toHaveBeenCalledTimes(1)
     expect(mockToggleButton.focus).not.toHaveBeenCalled()

diff --git a/typings/index.d.ts b/typings/index.d.ts
@@ -419,11 +419,11 @@ export interface UseSelectGetToggleButtonReturnValue
   tabIndex: 0
 }
 
-export interface UseSelectGetLabelPropsOptions extends GetLabelPropsOptions {
+export interface UseSelectGetLabelPropsOptions extends GetLabelPropsOptions {}
+export interface UseSelectGetLabelPropsReturnValue
+  extends GetLabelPropsReturnValue {
   onClick: React.MouseEventHandler
 }
-export interface UseSelectGetLabelPropsReturnValue
-  extends GetLabelPropsReturnValue {}
 
 export interface UseSelectGetItemPropsOptions<Item>
   extends Omit<GetItemPropsOptions<Item>, 'disabled'>,