-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update section purger plugin to sectionbundled #84
Update section purger plugin to sectionbundled #84
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Update hook looks good, I think we will also need to update config/install so when a new site installs baywatch they will have the bundled purger configured directly.
Removed hardcoded purger_id as the selector to update any section purger with any purger_id
Hey @GROwen would you mind having a review of this proposed change? There is a bundled purger plugin in the Section module which provides the ability to invalidate multiple tags in one request. This is an update hook to update the section purger configuration values for deployed sites (as they're not all using the config provided by Baywatch). |
// channel id is in the format of purger_section_{purger_id} | ||
$parts = explode('_', $channel['id']); | ||
$purger_id = end($parts); | ||
$channel['id'] = "purger_sectionbundled_$purger_id"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be
$channel['id'] = "purger_sectionbundled_$purger_id"; | |
$channel['id'] = "purger_sectionbundled_{$purger_id}"; |
Hey @steveworley and @MarkCalvert Is the sectionbundled purger an existing purger or do we need to bump the version of the module? Also, this belongs in https://github.com/dpc-sdp/bay_platform_dependencies/ We moved platform dependencies there a little while ago. |
Thanks @GROwen — sorry I forgot that platform deps were split out. Nope, the section module was bundled with this for a while — unsure why we didn't use this in the initial set up of the module. Will get it moved to the right place, thanks! |
Migrated PR to dpc-sdp/bay_platform_dependencies#3 |
No description provided.