Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update section purger plugin to sectionbundled #84

Conversation

MarkCalvert
Copy link

No description provided.

@MarkCalvert MarkCalvert self-assigned this Jun 1, 2023
Copy link

@steveworley steveworley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Update hook looks good, I think we will also need to update config/install so when a new site installs baywatch they will have the bundled purger configured directly.

Removed hardcoded purger_id as the selector to update any section purger with any purger_id
@steveworley
Copy link

Hey @GROwen would you mind having a review of this proposed change? There is a bundled purger plugin in the Section module which provides the ability to invalidate multiple tags in one request.

This is an update hook to update the section purger configuration values for deployed sites (as they're not all using the config provided by Baywatch).

// channel id is in the format of purger_section_{purger_id}
$parts = explode('_', $channel['id']);
$purger_id = end($parts);
$channel['id'] = "purger_sectionbundled_$purger_id";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be

Suggested change
$channel['id'] = "purger_sectionbundled_$purger_id";
$channel['id'] = "purger_sectionbundled_{$purger_id}";

@GROwen
Copy link
Contributor

GROwen commented Jun 7, 2023

Hey @steveworley and @MarkCalvert Is the sectionbundled purger an existing purger or do we need to bump the version of the module?

Also, this belongs in https://github.com/dpc-sdp/bay_platform_dependencies/ We moved platform dependencies there a little while ago.

@steveworley
Copy link

Thanks @GROwen — sorry I forgot that platform deps were split out. Nope, the section module was bundled with this for a while — unsure why we didn't use this in the initial set up of the module.

Will get it moved to the right place, thanks!

@steveworley steveworley closed this Jun 7, 2023
@MarkCalvert
Copy link
Author

MarkCalvert commented Jun 8, 2023

Migrated PR to dpc-sdp/bay_platform_dependencies#3

@MarkCalvert MarkCalvert deleted the feature/DEVOPS-207-Add-batch-purge-support-to-section_purger-module branch June 8, 2023 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants