Feature/SRM-871 d10 update #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 13c391b. Reverted token conditions changes.
Merged develop changes.
vincent-gao
force-pushed
the
feature/SRM-871-d10-update
branch
from
2186d40
to
f330a83
Compare
Merge develop branch changes.
krakerag
approved these changes
Nov 2, 2023
| "squizlabs/php_codesniffer": "3.7.1", | ||
| "dealerdirect/phpcodesniffer-composer-installer": "^0.7", | ||
| "drupal/coder": "^8.3.10", | ||
| "drupal/console": "^1.0", | ||
| "drupal/drupal-extension": "^4.1", | ||
| "drupal/console": "dev-feature/Symfony-config-d10-compatibility", |
There was a problem hiding this comment.
Is there a release now that supports this? I expect since D10 isn't as new now, there may well be
There was a problem hiding this comment.
@krakerag there is still a open PR for this - hechoendrupal/drupal-console#4348
There was a problem hiding this comment.
I'm sad that they haven't merged it yet, I guess that will have to do. As long as we lock a working version in the lock file we should be fine.
composer.json
Outdated
| @@ -4,7 +4,7 @@ | |||
| "license": "GPL-2.0-or-later", | |||
| "type": "drupal-module", | |||
| "require": { | |||
| "dpc-sdp/tide_core": "^3.1.0" | |||
| "dpc-sdp/tide_core": "dev-feature/SRM-870-d10-update" | |||
There was a problem hiding this comment.
Just remember to clean this up before merge (or after merge in a new PR etc)
mayurngondhkar
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.