-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SD-207] Accordion slots #1327
Merged
Merged
[SD-207] Accordion slots #1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
ripple-framework Run #2230
Run Properties:
|
Project |
ripple-framework
|
Branch Review |
feat/sd-207-accordion-slots
|
Run status |
Passed #2230
|
Run duration | 09m 31s |
Commit |
621ea1a9ee: refactor(@dpc-sdp/ripple-ui-core): :recycle: use a single collector index
|
Committer | Jason Smith |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
196
|
View all changes introduced in this branch ↗︎ |
lambry
reviewed
Sep 17, 2024
packages/ripple-ui-core/src/components/accordion/RplAccordion.vue
Outdated
Show resolved
Hide resolved
lambry
approved these changes
Sep 23, 2024
dylankelly
requested changes
Sep 24, 2024
Would be great to add cypress component test for both props and slot interfaces |
Merging this now to get in the release, will followup to add the cypress component test separately |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://digital-vic.atlassian.net/browse/SD-207
What I did
RplAccordionItem
child wrapper e.g.<p>Body content here</p>
not just text - the slot is handed to aRplContent
component.How to test
Checklist
For all PR's
For new components only