[SDPAP-8001] Fixes an issue for preview links #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent-gao
requested review from
krakerag,
anthony-malkoun,
MdNadimHossain and
RonaldRinaldy
krakerag
approved these changes
Jul 11, 2023
hi @krakerag , thanks for the CR. yes, I will raise a ticket for the QA team. |
There was a problem hiding this comment.
@vincent-gao weren't you going to look at why the administrator role was required? Seems like overkill.
|
@anthony-malkoun |
|
hi @anthony-malkoun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
https://digital-vic.atlassian.net/browse/SDPAP-8001
https://digital-vic.atlassian.net/browse/SDPSUP-5026
Issue
the last release reverted the configuration back to
previewerrole which causes the issue, @RonaldRinaldy just fixed it by applyingdrush config:set tide_share_link.settings token_role administrator, this PR is a follow-up PR to make the change permanently.