Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed references to GetCacheIdEvent::cacheId #134

Merged
merged 1 commit into from
May 14, 2024

Conversation

nicksantamaria
Copy link
Contributor

Fixes huge number of log messages like this

Deprecated function: Creation of dynamic property Drupal\tide_api\Event\GetCacheIdEvent::$cache_id is deprecated in Drupal\tide_api\Event\GetCacheIdEvent->__construct() (line 39 of /app/docroot/modules/contrib/tide_api/src/Event/GetCacheIdEvent.php) #0 /app/docroot/core/includes/bootstrap.inc(164): _drupal_error_handler_real()
#1 /app/docroot/modules/contrib/tide_api/src/Event/GetCacheIdEvent.php(39): _drupal_error_handler()
#2 /app/docroot/modules/contrib/tide_api/src/Controller/TideApiController.php(381): Drupal\tide_api\Event\GetCacheIdEvent->__construct()
#3 /app/docroot/modules/contrib/tide_api/src/Controller/TideApiController.php(163): Drupal\tide_api\Controller\TideApiController->initializeCacheId()
#4 [internal function]: Drupal\tide_api\Controller\TideApiController->getRoute()
#5 /app/docroot/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(123): call_user_func_array()
#6 /app/docroot/core/lib/Drupal/Core/Render/Renderer.php(

@nicksantamaria nicksantamaria merged commit db0dc0a into develop May 14, 2024
4 of 6 checks passed
@nicksantamaria nicksantamaria deleted the feature/fix-cacheId-property branch May 14, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants